Day 69 - Momentum · 301 Days (redux)

Table of Contents

In which we keep calm and carry on.

Test Every Day
#

APP_PROTOCOL
#

Not sure there’s a test for this value in the config file. A look through the code sees the character’s protocol field being checked against it, and when the SET_PROTOCOL message is received, the character’s protocol field is set to it. It’s never displayed, so whether it’s ‘Kesmai’ or ‘VT9999’ or ‘asdfasdf’ has no visible effect. Since the other two accepted values for a character’s protocol are ’normal’ and ‘old-kesmai’, setting APP_PROTOCOL to one of these would cause some confusion, but that’s more of a bug than anything else (arguably, the server should not allow APP_PROTOCOL to be set to either of those values).

So, we add two non-tests for now:

features/config_file.feature

GitLab

182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198


## APP_PROTOCOL

# bug - There are two special values, 'normal' and 'old-kesmai' that should not be allowed.
@bug
Scenario: APP_PROTOCOL set to invalid value - normal
	Given I use the "minimal" database as-is
	And I set "APP_PROTOCOL" in the config file to "normal"
	When the server is started
	Then the log shows a fatal error "Invalid APP_PROTOCOL"

# bug - There are two special values, 'normal' and 'old-kesmai' that should not be allowed.
@bug
Scenario: APP_PROTOCOL set to invalid value - old-kesmai
	Given I use the "minimal" database as-is
	And I set "APP_PROTOCOL" in the config file to "old-kesmai"
	When the server is started
	Then the log shows a fatal error "Invalid APP_PROTOCOL"

Work on the Blog Every Third Day
#

Still porting the blog over to a more vanilla Jekyll 3 (with the jekyll-clean-dark theme). Converting from Octopress 2 has involved some coding and a lot of search-and-replace: I’ve made a snippet of some of the useful regexes, and will probably publish a fork of the theme when I’m done.

I still have to touch each post, it seems, mostly looking for oddities where Octopress was handling Markdown differently. There’s a lot of temptation to improve the posts, but I’m resisting that endless timesink.

Here’s a preview.